Drop DataPlaneService ConfigMaps and Secrets #923
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: slagle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
slagle
force-pushed
the
service-datasources
branch
from
1f62f0b to
7dda707
Compare
|
/retest
|
slagle
force-pushed
the
service-datasources
branch
from
7dda707 to
2b8dd80
Compare
- Drops the ConfigMaps and Secrets fields from OpenStackDataPlaneService. - Updates all services under config/services to use the OpenStackDataPlaneService.Spec.DataSources field instead. - Removes some un-needed labels from some services as they aren't needed and for brevity. - Update docs for the switch to DataSources. Depends-On: openstack-k8s-operators/install_yamls#846 Depends-On: openstack-k8s-operators/ci-framework#1847 Depends-On: openstack-k8s-operators/architecture#276 Signed-off-by: James Slagle <[email protected]>
slagle
force-pushed
the
service-datasources
branch
from
2b8dd80 to
6f354e2
Compare
|
/retest
|
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/46856b5c6643467e99278a6a3156de87 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 02m 32s |
|
/retest |
|
/retest-required |
|
recheck |
|
@slagle: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
I don't think this will pass until openstack-operator is bumped to pick up the new runner image. |
|
This change depends on a change that failed to merge. Change openstack-k8s-operators/architecture#276 is needed. |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
OpenStackDataPlaneService.Spec.DataSources field instead.
and for brevity.
Depends-On: openstack-k8s-operators/install_yamls#846
Depends-On: openstack-k8s-operators/ci-framework#1847
Depends-On: openstack-k8s-operators/architecture#276
Signed-off-by: James Slagle [email protected]